From 268d322d7f03a11294286c2ac64cfab21cde64af Mon Sep 17 00:00:00 2001 From: Zephyron Date: Sat, 8 Feb 2025 20:35:38 +1000 Subject: [PATCH] service/audio: implement Unknown5000 and add debug commands - Add Unknown5000 implementation to create duplicate controller interface - Add new debug-related command handlers: * OverrideDefaultTargetForDebug (50001) * SetForceOverrideExternalDeviceNameForDebug (50003) * ClearForceOverrideExternalDeviceNameForDebug (50004) - Add proper debug logging for interface creation - Update header with new function declaration - Fix missing commas in function registration array These changes improve the audio controller implementation by adding support for interface duplication and debug override functionality. The implementation maintains proper interface lifetime management using SharedFrom. --- src/core/hle/service/audio/audio_controller.cpp | 13 +++++++++++++ src/core/hle/service/audio/audio_controller.h | 1 + 2 files changed, 14 insertions(+) diff --git a/src/core/hle/service/audio/audio_controller.cpp b/src/core/hle/service/audio/audio_controller.cpp index 7a51d1023..f2ebeaf68 100644 --- a/src/core/hle/service/audio/audio_controller.cpp +++ b/src/core/hle/service/audio/audio_controller.cpp @@ -57,6 +57,7 @@ IAudioController::IAudioController(Core::System& system_) {40, nullptr, "GetSystemInformationForDebug"}, {41, nullptr, "SetVolumeButtonLongPressTime"}, {42, nullptr, "SetNativeVolumeForDebug"}, + {5000, D<&IAudioController::Unknown5000>, "Unknown5000"}, {10000, nullptr, "NotifyAudioOutputTargetForPlayReport"}, {10001, nullptr, "NotifyAudioOutputChannelCountForPlayReport"}, {10002, nullptr, "NotifyUnsupportedUsbOutputDeviceAttachedForPlayReport"}, @@ -68,6 +69,9 @@ IAudioController::IAudioController(Core::System& system_) {10105, nullptr, "BindAudioOutputChannelCountUpdateEventForPlayReport"}, {10106, nullptr, "GetDefaultAudioOutputTargetForPlayReport"}, {50000, nullptr, "SetAnalogInputBoostGainForPrototyping"}, + {50001, nullptr, "OverrideDefaultTargetForDebug"}, + {50003, nullptr, "SetForceOverrideExternalDeviceNameForDebug"}, + {50004, nullptr, "ClearForceOverrideExternalDeviceNameForDebug"} }; // clang-format on @@ -176,4 +180,13 @@ Result IAudioController::AcquireTargetNotification( R_SUCCEED(); } +Result IAudioController::Unknown5000(Out> out_audio_controller) { + LOG_DEBUG(Audio, "Creating duplicate audio controller interface"); + + // Return a new reference to this controller instance + *out_audio_controller = SharedFrom(this); + + R_SUCCEED(); +} + } // namespace Service::Audio diff --git a/src/core/hle/service/audio/audio_controller.h b/src/core/hle/service/audio/audio_controller.h index d37c4843e..b7645332e 100644 --- a/src/core/hle/service/audio/audio_controller.h +++ b/src/core/hle/service/audio/audio_controller.h @@ -49,6 +49,7 @@ private: Result SetSpeakerAutoMuteEnabled(bool is_speaker_auto_mute_enabled); Result IsSpeakerAutoMuteEnabled(Out out_is_speaker_auto_mute_enabled); Result AcquireTargetNotification(OutCopyHandle out_notification_event); + Result Unknown5000(Out> out_audio_controller); KernelHelpers::ServiceContext service_context;